Open
Conversation
staabm
reviewed
Nov 14, 2025
Collaborator
|
This pull request has been marked as ready for review. |
Contributor
|
Does it also solve phpstan/phpstan#5952 ? |
staabm
reviewed
Jan 22, 2026
| ]); | ||
| } | ||
|
|
||
| public function testBug13806(): void |
Contributor
There was a problem hiding this comment.
I wonder why this test (and/or its result) does not depend on php version
ondrejmirtes
requested changes
Feb 10, 2026
| $toStringMethod = $scope->getMethodReflection($exprType, '__toString'); | ||
| if ($toStringMethod !== null) { | ||
| if ($this->phpVersion->throwsOnStringCast()) { | ||
| if ($toStringMethod->getThrowType() !== null) { |
Member
There was a problem hiding this comment.
Nice, almost perfect 😊 But I think we're missing a few things:
- It should support
@throws voidas a means to mark "this does not throw exceptions". - It should respect
$this->implicitThrows. When throwType isnull, if this property is true, it means an implicit throw point should be added. If this property is false, it means that__toStringdoes not throw an exception.
There's already code in NodeScopeResolver handling these things - getMethodThrowPoint. Should be possible to reuse it.
Contributor
Author
There was a problem hiding this comment.
- It already supports that, no? The test case reports dead catch on line 16.
- How can I test that? Or just re-using
getMethodThrowPointis enough?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#13806