add Type::isNever and Type::isExplicitNever methods#4547
add Type::isNever and Type::isExplicitNever methods#4547canvural wants to merge 3 commits intophpstan:2.1.xfrom
Conversation
|
I disagree about it. There's nothing wrong about this signature: /**
* @template T of BackedEnum
* @param class-string<T> $class
* @param value-of<T> $value
*/I feel like UnresolvableTypeHelper should skip LateResolvableTypes. |
|
I think that'd just hide the error. Currently Edit: I copied the snippet you referenced and the fix from #4548 and looks like that fixes it without the need of skipping LateResolvableTypes in UnresolvableTypeHelper |
|
I'm sorry about sleeping on this. There are now conflicts. Please fix rebase and fix them. At least meanwhile I merged #4548. |
|
Amazing. Yeah, I was waiting for that PR to be merged first. Will do in the evening 👍🏽 |
|
@ondrejmirtes Rebased and refactored new usages to methods too. There is one test failing locally. Here it doesn't report error anymore. @VincentLanglet maybe you have any insights? |
Re-opening #4545
I think the issue bot changes are valid and is the same case as I described here