zend_ini: Make ZEND_INI_GET_ADDR() return a void* pointer
#21119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the actual type of the storage location is not known, a `void*` is more appropriate and avoids explicit casts that are no more safe than the implicit cast from `void*`.
TimWolla
requested review from
Girgias,
SakiTakamachi,
bukka,
devnexen,
dstogov and
ndossche
as code owners
iluuu1994
approved these changes
Feb 3, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
LGTM. Don't forget the note in UPGRADING.INTERNALS, void* pointer arithmetics don't reliably warn in compilers.
Member
Author
sigh, thanks for the hint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the actual type of the storage location is not known, a
void*is more appropriate and avoids explicit casts that are no more safe than the implicit cast fromvoid*.