Skip to content

Conversation

@jimwins
Copy link
Member

@jimwins jimwins commented Sep 18, 2024

Trying to put more emphasis/information on how to install from packages (either from distributions or third parties) and for Unix, in particular, move the stuff about compiling from source down a level so new users don't get knocked in the face with it.

@jimwins
Copy link
Member Author

jimwins commented Sep 18, 2024

The 'DNF' section is based on the Debian one, but could certainly use review by someone who actually uses a DNF-based system, because that's not me. Also not sure if it should treat Yum and DNF like the Debian section does with apt and aptitude.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for tackling this long overdue update!

Unfortunately, I can't help much with the details about installing on non Windows systems. Hopefully, some others can provide useful comments.

@jimwins jimwins marked this pull request as ready for review September 21, 2024 22:34
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more markup comments

@jimwins
Copy link
Member Author

jimwins commented Sep 24, 2024

Instead of spamming a half-dozen "done!" comments, here's one to note that all of the feedback from @Girgias was addressed. The build fails now because I moved some entities into doc-base and that needs to land first.

Girgias pushed a commit to php/doc-base that referenced this pull request Sep 24, 2024
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final comment and LGTM.

Thanks for tackling this!

@jimwins jimwins merged commit 4cb53ec into php:master Sep 24, 2024
@jimwins jimwins deleted the clean-up-installation-instructions branch September 24, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants