Skip to content

fix: when both lp edit and dismiss edit classes, tool boxes not getting dismissed #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 1 commit into from
Jan 13, 2026
+8 −8
Merged

fix: when both lp edit and dismiss edit classes, tool boxes not getting dismissed #2588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,10 +492,7 @@
// Get the user's current selection
const selection = window.getSelection();
var element = event.target;
if(element && (element.closest('.phcode-no-lp-edit') || element.classList.contains('phcode-no-lp-edit-this'))) {
return;
}
// Check for dismiss action - dismiss LP editing when clicked
// Check for dismiss action first - dismiss LP editing when clicked (takes precedence over no-edit)
if(element && (element.closest('.phcode-dismiss-lp-edit')
|| element.classList.contains('phcode-dismiss-lp-edit-this'))) {
// dismissUIAndCleanupState is in RemoteFunctions, accessible via window._LD
Expand All @@ -506,6 +503,9 @@
event.stopPropagation();
return;
}
if(element && (element.closest('.phcode-no-lp-edit') || element.classList.contains('phcode-no-lp-edit-this'))) {
return;
}
if (element && element.hasAttribute('data-brackets-id')) {
// Check if it's a double-click for direct editing
if (event.detail === 2 && !['INPUT', 'TEXTAREA', 'SELECT'].includes(element.tagName)) {
Expand Down
8 changes: 4 additions & 4 deletions src/LiveDevelopment/BrowserScripts/RemoteFunctions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,17 +756,17 @@ function RemoteFunctions(config = {}) {
* @param {Event} event - The click event
*/
function handleElementClick(element, event) {
if(element && (element.closest('.phcode-no-lp-edit') || element.classList.contains('phcode-no-lp-edit-this'))) {
return;
}
// Check for dismiss action - dismiss LP editing when clicked
// Check for dismiss action first - dismiss LP editing when clicked (takes precedence over no-edit)
if(element && (
element.closest('.phcode-dismiss-lp-edit') || element.classList.contains('phcode-dismiss-lp-edit-this'))) {
dismissUIAndCleanupState();
event.preventDefault();
event.stopPropagation();
return;
}
if(element && (element.closest('.phcode-no-lp-edit') || element.classList.contains('phcode-no-lp-edit-this'))) {
return;
}
if (!LivePreviewView.isElementInspectable(element)) {
dismissUIAndCleanupState();
return;
Expand Down
Loading