Skip to content

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Jan 9, 2026

Rename Condition Pattern Fields for Better Clarity

This PR renames the database fields and function parameters related to step conditions to improve clarity and better reflect their purpose:

  • Renamed condition_pattern to required_input_pattern to clearly indicate that this pattern must be present in the input
  • Renamed condition_not_pattern to forbidden_input_pattern to clearly indicate that this pattern must not be present in the input

These changes make the code more self-documenting and align with the semantic meaning of these fields. The renaming is consistent across:

  • Database schema definitions
  • SQL functions
  • TypeScript type definitions
  • Flow shape extraction and comparison logic

All tests have been updated to use the new field names, and the functionality remains unchanged.

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2026

⚠️ No Changeset found

Latest commit: acd3e0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2026

View your CI Pipeline Execution ↗ for commit acd3e0e

Command Status Duration Result
nx run edge-worker:test:integration ✅ Succeeded 3m 50s View ↗
nx affected -t verify-exports --base=origin/mai... ✅ Succeeded 3s View ↗
nx affected -t build --configuration=production... ✅ Succeeded 3s View ↗
nx affected -t lint typecheck test --parallel -... ✅ Succeeded 2m 23s View ↗
nx run client:e2e ✅ Succeeded 1m 9s View ↗
nx run cli:e2e ✅ Succeeded 4s View ↗
nx run edge-worker:e2e ✅ Succeeded 48s View ↗
nx run core:pgtap ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-09 17:40:57 UTC

@jumski jumski force-pushed the 01-09-pgf-3hs.14_add_condition_fields_to_flowshape_for_auto-compilation branch from 38446ea to acd3e0e Compare January 9, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants