Update Contributing Document - 18 #908
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the contributing guide.
Andriciuc
changed the title
nastena1606
reviewed
Jan 14, 2026
nastena1606
reviewed
Jan 14, 2026
nastena1606
reviewed
Jan 14, 2026
nastena1606
reviewed
Jan 14, 2026
nastena1606
reviewed
Jan 14, 2026
| docker run --rm -v $(pwd):/docs perconalab/pmm-doc-md mkdocs build | ||
| git add . | ||
| git commit -m "<my_fixes>" | ||
| git push -u origin <my_branch_name> |
Contributor
There was a problem hiding this comment.
git push -u origin <my_branch_name>. Otherwise upstream repo is unaware of this change
Contributor
Author
There was a problem hiding this comment.
Shouldn't users push the branch to their fork (origin), and not to upstream? If the user does a pull request (step 7), then the upstream repository identifies the changes.
It's the way I am pushing upstream PRs as well, did I understand this incorrectly?
Contributor
There was a problem hiding this comment.
@Andriciuc I followed your instructions from the very first step, and I managed to create a PR with git push -u origin <my_branch_name>.
nastena1606
reviewed
Jan 14, 2026
nastena1606
reviewed
Jan 14, 2026
Co-authored-by: Anastasia Alexandrova <anastasia.alexandrova@percona.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the contributing guide.