feat: add missing disableErrors to globals findOne operation #14913
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rilrom
force-pushed
the
feat/add-missing-disable-errors-option
branch
from
9cb8085 to
21d54f0
Compare
Contributor
Author
|
Converting to draft until I have time to resolve build errors. |
rilrom
force-pushed
the
feat/add-missing-disable-errors-option
branch
2 times, most recently
from
23a56d3 to
155c769
Compare
rilrom
changed the title
rilrom
changed the title
rilrom
force-pushed
the
feat/add-missing-disable-errors-option
branch
from
155c769 to
9ebdc43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces the
disableErrorsoption into the globalfindOneoperation.Why?
disableErrorsis handy for certain flows where a user may be unauthorised but you don't need an error to be thrown, instead you would prefer an empty result.Without this, the developer needs to catch the error themselves, leading to inconsistencies as some operations have
disableErrorsand others do not.How?
Introduced the
disableErrorsoption to the globalfindOneoperation.Additional information
disableErrorsin a number of operations that seem to be lacking it, especially in thesdkpackage. Originally I included these changes in this PR but have since removed to instead allow for some discussion before we consider introducing them in a separate PR.packages/payload/src/collections/operations/restoreVersion.ts,disableErrorsexists in the types but is not actually implemented. I have left this as is for now but wanted to flag it.