This repository was archived by the owner on Feb 7, 2023. It is now read-only.
resolves issue#15 update to bootstrap v4#18
Open
bernhardriegler wants to merge 2 commits intopattern-lab:masterfrom
Open
resolves issue#15 update to bootstrap v4#18bernhardriegler wants to merge 2 commits intopattern-lab:masterfrom
bernhardriegler wants to merge 2 commits intopattern-lab:masterfrom
Conversation
bernhardriegler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
starting patternlab did fail. I found that the folders in _patterns/00-atoms/ did start with 01-global.
Renaming it to 00-global did resolve this issue.
I did check on the existing components briefly. They do not show all available bootstrap features. I did update those where new classes were required.
Additional work can be done creating all the new bootstrap components.