GH1541 Revert Series[Any].__add__(str) #1542
Open
+34
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicdiridollou
requested review from
Dr-Irv and
cmp0xff
and removed request for
Dr-Irv
Dr-Irv
requested changes
Dec 10, 2025
cmp0xff
requested changes
Dec 10, 2025
cmp0xff
requested changes
Dec 13, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
I think we still miss a few tests.
I also plan to simplify the tests structure for arithmetic operations, removing the arithmetic subfolder and move everything one level above. Hopefully this will confuse people less in the future.
| def pivot_table( | ||
| data: DataFrame, | ||
| values: _PivotTableValuesTypes[ | ||
| values: _PivotTableValuesTypes[ # ty: ignore[non-subscriptable] |
Contributor
There was a problem hiding this comment.
It's a bit surprising that we now need to ty: ignore's here. Would be great if you could report it to ty.
| def __gt__(self, other: Self | S1) -> np_1darray_bool: ... # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride] | ||
| @overload | ||
| def __add__(self: Index[Never], other: _str) -> Never: ... | ||
| def __add__(self: Index[Never], other: _str) -> Index[_str]: ... |
Contributor
There was a problem hiding this comment.
Please add tests in tests/indexes/arithmetic/test_add.py
| sr = df[0] | ||
|
|
||
| check(assert_type(sr + "c1", "pd.Series[str]"), pd.Series, str) | ||
| check(assert_type("c1" + sr, "pd.Series[str]"), pd.Series, str) |
Contributor
There was a problem hiding this comment.
series/arithmetic/str/test_add.pyis meant to test for knownSeries[str]. ForSeries[Any]at type checking, the plan is to useseries/arithmetic/test_add.py. Please move this part there.- We also have a
left_str = pd.DataFrame({"a": ["1", "2", "3_"]})["a"]defined in that file.
- We also have a
- Please also make the undunder methods
addandraddwork
Comment on lines
+4
to
+6
| from typing import ( | ||
| TypeAlias, | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| from typing import ( | |
| TypeAlias, | |
| ) | |
| from typing import TypeAlias |
Comment on lines
5
to
7
| from typing_extensions import ( | ||
| Never, | ||
| assert_type, | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| from typing_extensions import ( | |
| Never, | |
| assert_type, | |
| ) | |
| from typing_extensions import assert_type |
| if TYPE_CHECKING_INVALID_USAGE: | ||
| assert_type(left_i + s, Never) | ||
| assert_type(s + left_i, Never) | ||
| # relaxing typing, won't work at runtime though |
Contributor
There was a problem hiding this comment.
Suggested change
| # relaxing typing, won't work at runtime though | |
| # GH1541 relaxing typing, won't work at runtime though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value)AGENTS.md.