fix: show full option name in error for invalid multi-char short options#3207
Closed
by22Jy wants to merge 1 commit intopallets:mainfrom
Closed
fix: show full option name in error for invalid multi-char short options#3207by22Jy wants to merge 1 commit intopallets:mainfrom
by22Jy wants to merge 1 commit intopallets:mainfrom
Conversation
When a multi-character short option like `-dbgwrong` is passed and fails validation, the error message now shows the full option name instead of just the first character. Before: No such option: -d After: No such option: -dbgwrong Fixes pallets#2779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-dbgwrongfails validation, the error message now shows the full option name instead of just the first character.Context
Fixes #2779
Previously, when passing an invalid multi-character short option (e.g.,
-dbgwrong), the error would only show the first character:This was confusing because the user passed
-dbgwrong, not-d.Changes
Now the error correctly shows the full option name:
The fix captures the remaining characters when a short option fails to match and includes them in the error message.
Testing
Tested manually with a Click app:
Running
python test.py -dbgwrongnow shows: