Do not require flower authentication, nginx already handles it #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change I can access the api/queues/length endpoint: curl -u "nginx-usr:nginx-pwd" "https://workers.stg.packit.dev/api/queues/length" otherwise I can't.
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 33s |
Member
|
@majamassarini what about authentication with ? Have you tried utilise this somehow? |
Member
Author
yes, this is actually the nginx password. This is why the flower authentication shouldn't be needed. At the moment, we are only allowed to see those pages directly mapped in nginx -> /flower-metrics and /. But there are more pages flower exposes (like /queues/length or /tasks) which we can't access because of the above restriction. |
lbarcziova
approved these changes
Jan 23, 2026
Member
lbarcziova
left a comment
lbarcziova
left a comment
There was a problem hiding this comment.
resolved via chat, there is still the layer of auth via nginx, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change I can access the api/queues/length endpoint:
curl -u "nginx-usr:nginx-pwd" "https://workers.stg.packit.dev/api/queues/length"
otherwise I can't.