fix(web-pkg): [OCISDEV-553] filter only personal trashed spaces #13415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of filtering all trashed spaces, we now filter only personal trashed spaces. This fixes the issue where listing spaces with "Include disabled" option toggled did not show disabled spaces.
|
mzner
reviewed
Jan 2, 2026
| expect.anything() | ||
| ) | ||
| expect(instance.spaces.length).toBe(2) | ||
| expect(instance.spaces.length).toBe(4) |
Contributor
There was a problem hiding this comment.
Should that be 2 or 4? I can only see two with trashed state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of filtering all trashed spaces, we now filter only personal trashed spaces. This fixes the issue where listing spaces with "Include disabled" option toggled did not show disabled spaces.
Motivation and Context
Disabled project spaces are again listable.
How Has This Been Tested?
Types of changes