feat: add support for single-sign-on via openid connect authentication #16
Conversation
|
There is a draft PR here that shows how these changes would be incorporated into the oc-accelerator. Whoever reviews this PR can use this to validate changes. |
includes redirecting users to the identity provider and handling the response
| * @returns An object with: | ||
| * - run: the deduplicated function | ||
| * - isRunning: boolean indicating whether the function is currently executing | ||
| */ |
There was a problem hiding this comment.
I had to use this with verifyToken to solve a race condition I was facing where a second invocation thought I wasn't logged in even though I was.
| Tokens.RemoveRefreshToken(); | ||
| setIsAuthenticated(false); | ||
| setIsLoggedIn(false); | ||
| setToken(undefined); |
There was a problem hiding this comment.
This was part of the troubleshooting I was doing with the race condition bug. It probably doesn't matter but setIsAuthenticated(false) will trigger verifyToken which relies on the values of the token so it makes sense that we clear out the tokens here first before setting isAuthenticated to false
erincdustin
left a comment
erincdustin
left a comment
There was a problem hiding this comment.
looks great, validated with the accelerator branch
2 participants
includes redirecting users to the identity provider and handling the response