Add SmithyModelExtensions and KebabCase method#1
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces new helper methods for both model shapes and naming conversions.
- Added two shape retrieval extension methods in SmithyModelExtensions.cs.
- Introduced a new KebabCase method in NamingUtils.cs to convert strings to kebab-case.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Smithy.Model/SmithyModelExtensions.cs | Adds GetShape and GetShape extension methods for retrieving shapes. |
| Smithy.CSharpGenerator/Utils/NamingUtils.cs | Updates formatting in PascalCase and adds a new KebabCase method for string conversion. |
Comment on lines
+25
to
+31
|
|
||
| for (int i = 0; i < id.Length; i++) | ||
| { | ||
| if (i > 0 && char.IsUpper(id[i])) | ||
| { | ||
| sb.Append('-'); | ||
| } |
There was a problem hiding this comment.
[nitpick] Consider enhancing the KebabCase method to better handle sequences of uppercase letters (e.g., abbreviations like 'XMLHttpRequest') to ensure consistent and expected output, or document the current behavior clearly.
Suggested change
| for (int i = 0; i < id.Length; i++) | |
| { | |
| if (i > 0 && char.IsUpper(id[i])) | |
| { | |
| sb.Append('-'); | |
| } | |
| bool previousWasUpper = false; | |
| for (int i = 0; i < id.Length; i++) | |
| { | |
| if (char.IsUpper(id[i])) | |
| { | |
| if (i > 0 && !previousWasUpper) | |
| { | |
| sb.Append('-'); | |
| } | |
| previousWasUpper = true; | |
| } | |
| else | |
| { | |
| previousWasUpper = false; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.