Use actual re.sub() regex-replace rather than str.replace(), since we…#81
Open
JeffSaxeVA wants to merge 1 commit intoopsgenie:masterfrom
Open
Use actual re.sub() regex-replace rather than str.replace(), since we…#81JeffSaxeVA wants to merge 1 commit intoopsgenie:masterfrom
JeffSaxeVA wants to merge 1 commit intoopsgenie:masterfrom
Conversation
… want to eliminate all varieties of whitespace from the Labels sent to Jira.
|
Hi @JeffSaxeVA, you can track the progress about the issue from this ticket |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… want to eliminate all varieties of whitespace from the Labels sent to Jira.
I noticed that the code to make a Label out of the alias name was evidently intending to remove all whitespace from the name, since spaces are not permitted in a Label on the Jira side. However, the str.replace() function recognizes only static strings, not character classes or other regex constructs; it was looking for literally backslash-s in the original text, so it would not even remove spaces. Since the "re" module is in the core library in both Python 2.x and 3.x, I propose importing that and using re.sub(). Thanks!