🌱 test: ensure single/own namespace increase coverage for both runtimes #2463

camilamacedo86 · 2026-01-28T15:31:25Z

Add E2E test scenarios for single/own namespace support that run for
both Helm and Boxcutter runtimes:

Invalid DNS-1123 watchNamespace - tests namespace name validation
Reject watchNamespace for AllNamespaces-only operators

Tests use assertions compatible with both runtimes. Unit tests in
provider_test.go provide comprehensive validation coverage via shared
RegistryV1ManifestProvider.

Achieves 100% parity with downstream OCP test coverage.

netlify · 2026-01-28T15:31:31Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`feeed73`
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/697cd227e3d9290008b004e6
😎 Deploy Preview	https://deploy-preview-2463--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Adds new E2E coverage for Single/OwnNamespace install behavior in ClusterExtension installation scenarios.

Changes:

Adds a scenario asserting the extension retries when watchNamespace points to a namespace that doesn’t exist.
Adds a scenario asserting a bundle that doesn’t support Single/OwnNamespace mode rejects watchNamespace config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/e2e/features/install.feature

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/e2e/features/install.feature

codecov · 2026-01-28T16:05:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.46%. Comparing base (4d4f894) to head (feeed73).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
- Coverage   69.48%   69.46%   -0.03%     
==========================================
  Files         102      102              
  Lines        8249     8249              
==========================================
- Hits         5732     5730       -2     
- Misses       2063     2064       +1     
- Partials      454      455       +1

Flag	Coverage Δ
e2e	`47.00% <ø> (+0.13%)`	⬆️
experimental-e2e	`13.34% <ø> (-0.06%)`	⬇️
unit	`57.52% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tmshort · 2026-01-28T20:12:13Z

/approve

camilamacedo86 · 2026-01-29T06:49:22Z

test/e2e/features/install.feature

+      """
+    Then ClusterExtension reports Progressing as True with Reason Retrying and Message includes:
+      """
+      watchNamespace


I am adding the test cases.
When we fix the Boxcutter, we have the Reason Failed
We can supplement those tests to ensure that False and Reason Failed for those cases.

test/e2e/features/install.feature

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Add E2E test scenarios for single/own namespace support that run for both Helm and Boxcutter runtimes: 1. Invalid DNS-1123 watchNamespace - tests namespace name validation 2. Reject watchNamespace for AllNamespaces-only operators Tests use assertions compatible with both runtimes. Unit tests in provider_test.go provide comprehensive validation coverage via shared RegistryV1ManifestProvider. Achieves 100% parity with downstream OCP test coverage.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/e2e/features/install.feature

Enhance both new test scenarios with more complete error message assertions: 1. DNS-1123 validation test: Now checks for the full error context including "invalid ClusterExtension configuration: invalid target namespaces [invalid-namespace-]: a lowercase RFC 1123 subdomain..." instead of just "lowercase RFC 1123". 2. AllNamespaces operator rejection test: Now verifies the complete error about "invalid ClusterExtension configuration: supported install modes [AllNamespaces] do not support target namespaces" instead of just "watchNamespace". These more comprehensive assertions better demonstrate that proper validation is occurring and provide clearer test documentation of the expected error behavior. Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>

camilamacedo86 · 2026-01-30T16:08:05Z

@pedjak All addressed could it win your LGTM now ?
WDYT?

pedjak

/lgtm

openshift-ci · 2026-01-30T18:30:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pedjak,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI review requested due to automatic review settings January 28, 2026 15:31

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2026

openshift-ci bot requested review from grokspawn and tmshort January 28, 2026 15:31

Copilot started reviewing on behalf of camilamacedo86 January 28, 2026 15:31 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

test/e2e/features/install.feature Outdated Show resolved Hide resolved

test/e2e/features/install.feature Outdated Show resolved Hide resolved

test/e2e/features/install.feature Outdated Show resolved Hide resolved

test/e2e/features/install.feature Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the fix-single-onw-boxcuter branch 2 times, most recently from 990f1ea to e44026d Compare January 28, 2026 15:40

Copilot AI review requested due to automatic review settings January 28, 2026 15:40

Copilot started reviewing on behalf of camilamacedo86 January 28, 2026 15:41 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

test/e2e/features/install.feature Show resolved Hide resolved

camilamacedo86 force-pushed the fix-single-onw-boxcuter branch from e44026d to b3a27c1 Compare January 28, 2026 15:46

camilamacedo86 changed the title ~~WIP test: ensure single/own namespace increase coverage for both runtimes~~ 🌱 test: ensure single/own namespace increase coverage for both runtimes Jan 28, 2026

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2026

camilamacedo86 commented Jan 29, 2026

View reviewed changes

camilamacedo86 closed this Jan 29, 2026

camilamacedo86 reopened this Jan 29, 2026

pedjak reviewed Jan 30, 2026

View reviewed changes

test/e2e/features/install.feature Show resolved Hide resolved

test/e2e/features/install.feature Show resolved Hide resolved

Copilot AI review requested due to automatic review settings January 30, 2026 12:08

camilamacedo86 force-pushed the fix-single-onw-boxcuter branch from b3a27c1 to a2274ef Compare January 30, 2026 12:08

Copilot started reviewing on behalf of camilamacedo86 January 30, 2026 12:08 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

camilamacedo86 force-pushed the fix-single-onw-boxcuter branch from a2274ef to 8ad72e8 Compare January 30, 2026 12:17

camilamacedo86 force-pushed the fix-single-onw-boxcuter branch from 8ad72e8 to 4b2a0cd Compare January 30, 2026 15:25

Copilot AI review requested due to automatic review settings January 30, 2026 15:25

Copilot started reviewing on behalf of camilamacedo86 January 30, 2026 15:25 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

test/e2e/features/install.feature Outdated Show resolved Hide resolved

camilamacedo86 force-pushed the fix-single-onw-boxcuter branch from 4b2a0cd to feeed73 Compare January 30, 2026 15:45

pedjak approved these changes Jan 30, 2026

View reviewed changes

openshift-ci bot assigned pedjak Jan 30, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026

openshift-merge-bot bot merged commit 5c4bf7b into operator-framework:main Jan 30, 2026
34 of 35 checks passed

camilamacedo86 deleted the fix-single-onw-boxcuter branch January 31, 2026 00:19

🌱 test: ensure single/own namespace increase coverage for both runtimes #2463

🌱 test: ensure single/own namespace increase coverage for both runtimes #2463

Conversation

camilamacedo86 commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for olmv1 ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codecov bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tmshort commented Jan 28, 2026

Uh oh!

camilamacedo86 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

camilamacedo86 commented Jan 30, 2026

Uh oh!

pedjak left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camilamacedo86 commented Jan 28, 2026 •

edited

Loading

netlify bot commented Jan 28, 2026 •

edited

Loading

codecov bot commented Jan 28, 2026 •

edited

Loading