move binary dependency management to bingo #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #471 +/- ##
==========================================
+ Coverage 37.78% 37.86% +0.08%
==========================================
Files 57 57
Lines 4557 4563 +6
==========================================
+ Hits 1722 1728 +6
Misses 2678 2678
Partials 157 157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: grokspawn <jordan@nimblewidget.com>
grokspawn
force-pushed
the
shift-tools-to-bingo
branch
from
5186aea to
21782a2
Compare
tmshort
reviewed
Jan 27, 2026
Signed-off-by: grokspawn <jordan@nimblewidget.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rashmigottipati The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the retrieval of binaries to bingo, because otherwise there is no version comparison here, and since the acquisition makes no version comparison, it's trivial to see version drift between the upstream and users' local environments, and there's no check to prevent this. Instead, a user would literally have to identify that some of the generated artifacts from
make manifestsshouldn't have been generated.This new approach will make the version checks explicit, tied to go version dependency management, and independent of user environments.