[qa] Add --ignore-pattern option to exclude files from QA checks #299#461
Open
aoutifrak wants to merge 8 commits intoopenwisp:masterfrom
Open
[qa] Add --ignore-pattern option to exclude files from QA checks #299#461aoutifrak wants to merge 8 commits intoopenwisp:masterfrom
aoutifrak wants to merge 8 commits intoopenwisp:masterfrom
Conversation
devkapilbansal
requested changes
Apr 2, 2025
Member
devkapilbansal
left a comment
devkapilbansal
left a comment
There was a problem hiding this comment.
Thanks for this @aoutifrak,
Please address the comments below. Also, comments should be added to explain why a change in done instead of what is done. Please avoid comments where they are not necessary
aoutifrak
commented
Apr 2, 2025
Contributor
Author
aoutifrak
left a comment
aoutifrak
left a comment
There was a problem hiding this comment.
changes are made
aoutifrak
force-pushed
the
ignore-files-qa-check-299
branch
2 times, most recently
from
6424226 to
910931d
Compare
codesankalp
requested changes
Apr 2, 2025
Member
codesankalp
left a comment
codesankalp
left a comment
There was a problem hiding this comment.
looks good 👍 , It will need some more modifications. please have a look at the comments below and give it a try with different scenarios.
Member
|
Also, please remove trailing whitespaces from your changes. |
aoutifrak
force-pushed
the
ignore-files-qa-check-299
branch
from
e4d7b65 to
910931d
Compare
devkapilbansal
requested changes
Apr 3, 2025
aoutifrak
force-pushed
the
ignore-files-qa-check-299
branch
from
5d53376 to
910931d
Compare
devkapilbansal
requested changes
Apr 3, 2025
devkapilbansal
requested changes
Apr 11, 2025
Member
devkapilbansal
left a comment
devkapilbansal
left a comment
There was a problem hiding this comment.
@aoutifrak Looks good, but the tests for this are missing. Kindly add relevant test cases also
…wisp#299 - Introduced --ignore-pattern <file_pattern> option to allow users to exclude specific files or directories. - Supports ignoring patterns like node_modules and env, which are unnecessary for QA checks. - Ensured compatibility with existing QA check functionality. This enhancement provides flexibility in excluding non-essential files Fixes openwisp#299
…wisp#299 - Introduced --ignore-pattern <file_pattern> option to allow users to exclude specific files or directories. Fixes openwisp#299
…wisp#299 - Introduced --ignore-pattern <file_pattern> option to allow users to exclude specific files or directories. - Supports ignoring patterns like node_modules and env, which are unnecessary for QA checks. - Ensured compatibility with existing QA check functionality. This enhancement provides flexibility in excluding non-essential files Fixes openwisp#299
devkapilbansal
force-pushed
the
ignore-files-qa-check-299
branch
from
08b97d2 to
792dddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhancement provides flexibility in excluding non-essential files
Fixes #299
Checklist
Reference to Existing Issue
Closes #.
Please open a new issue if there isn't an existing issue yet.
Description of Changes
Please describe these changes.
Screenshot
Please include any relevant screenshots.