Remove the Moodle authentication module. #2884
Merged
+0
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module is broken and I am rather certain it can't even be fixed. It uses an archaic and rather unsecure approach of trying to read cookies from Moodle and using that for authentication. In most cases this would be a cross domain cookie and most likely impossible to read. This approach might have worked a long time ago, but cookie's have changed a lot since then.
somiaj
approved these changes
Jan 9, 2026
pstaabp
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is broken and I am rather certain it can't even be fixed. It uses an archaic and rather unsecure approach of trying to read cookies from Moodle and using that for authentication. In most cases this would be a cross domain cookie and most likely impossible to read. This approach might have worked a long time ago, but cookie's have changed a lot since then.