Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
liquidity_delta.abs() panics on i64::MIN
pallets/swap/src/pallet/impls.rsliquidity_delta.abs()on a user-suppliedi64panics in debug / overflow-check builds when the value isi64::MIN. In production WASM release builds, wrapping semantics cause the value to fail theensurecheck harmlessly. No production impact, but the code is undefined behavior-adjacent in debug builds.Type of Change
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctly