Skip to content

Conversation

grbIzl and others added 30 commits November 24, 2025 16:41
Prompt: "make a sudo-only hyperparameter for the delay before calling
start call which is hardcoded to 50400 or 7*7200 currently"

This commit converts the hardcoded DurationOfStartCall constant (50400
blocks, or ~7 days) into a runtime-configurable hyperparameter called
StartCallDelay that can be modified via sudo extrinsic.

Changes:
- Added StartCallDelay storage value with DefaultStartCallDelay type_value
- Renamed DurationOfStartCall config constant to InitialStartCallDelay
- Added StartCallDelaySet event for hyperparameter updates
- Added get_start_call_delay() and set_start_call_delay() functions
- Added sudo_set_start_call_delay() extrinsic in admin-utils (call_index 84)
- Updated subnet.rs to read from storage instead of config constant
- Updated runtime constant from DurationOfStartCall to InitialStartCallDelay
- Updated all mock files and test usages to use new parameter name
- Updated benchmarks and tests to use StartCallDelay::<T>::get()

The delay can now be modified at runtime via the sudo_set_start_call_delay()
extrinsic without requiring a runtime upgrade, providing more flexibility
for network governance.

Users can read the current value through:
- Direct storage queries via state_getStorage RPC call
- The get_start_call_delay() getter function for internal use
- Client libraries (polkadot-js, subxt) which auto-generate storage accessors
Added test_sudo_set_start_call_delay_permissions_and_zero_delay which:

1. Verifies permission checking - non-root accounts cannot set the delay
2. Creates a subnet
3. Attempts to start it immediately - FAILS (delay not passed)
4. Sets delay to zero via sudo_set_start_call_delay()
5. Verifies StartCallDelaySet event is emitted
6. Attempts to start the same subnet again - SUCCEEDS (delay now zero)
7. Attempts to start it a third time - FAILS (already started)

This test validates the key scenario: a subnet that couldn't be started
due to the delay can be started after reducing the delay to zero, proving
the hyperparameter change takes immediate effect. The test calls start_call
three times to thoroughly verify the state transitions and confirms the
proper event is emitted when the delay is changed.
DefaultPendingChildKeyCooldown was returning 0 instead of using the
same value as DefaultPendingCooldown. This causes PendingChildKeyCooldown
to be 0 on fresh chains (like localnet) instead of the expected 7200/15.

Changed to call DefaultPendingCooldown::<T>::get() for consistency.

Fixes #2107
Replace all references to DurationOfStartCall with InitialStartCallDelay
to match the renamed constant in the codebase.

Improvements:
- Updated variable names from DurationOfStartCall to InitialStartCallDelay
- Updated grep checks to look for the new constant name
- Updated perl replacements to modify the new constant name
- Added clear error messages for all replacement failures
- Added context messages explaining that codebase may have changed
- Added progress indicator when applying patches
- Enhanced final success message with checkmark
Eliminates code duplication by consolidating check and replace logic into a single function, improving maintainability and making it easier to add new patches.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Renames DurationOfStartCall to InitialStartCallDelay in TypeScript contract tests to match the renamed runtime constant.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Involve subtensor tx extension in contracts
…iled-drain_for_block

Mevshield - Improve Error Handling
…dkey-cooldown

fix: DefaultPendingChildKeyCooldown should use prod_or_fast value
ppolewicz and others added 26 commits January 14, 2026 17:39
Coldkey stake on subnet and evm to accountId
Set default weights for system pallets.
…nt-update-dependency

update dependency for transaction replacement env
@sam0x17 sam0x17 self-assigned this Jan 19, 2026
@sam0x17 sam0x17 added skip-cargo-audit This PR fails cargo audit but needs to be merged anyway deploy-devnet labels Jan 19, 2026
@sam0x17 sam0x17 merged commit 11a587e into devnet Jan 19, 2026
185 of 193 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy-devnet skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.