[multiple] Improve cifmw_project_dir group var name #3583
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
amartyasinha
force-pushed
the
improve_var_name
branch
from
95f3e9c to
e5f9b2d
Compare
|
zuul gate jobs were stuck for unknown reason. this force commit adds nothing, just meant to retrigger the jobs. |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
amartyasinha
force-pushed
the
improve_var_name
branch
from
e5f9b2d to
e25bf75
Compare
|
Merging blocked as gate job |
|
recheck |
amartyasinha
force-pushed
the
improve_var_name
branch
from
e25bf75 to
c1ea450
Compare
amartyasinha
force-pushed
the
improve_var_name
branch
3 times, most recently
from
2c986a9 to
221cf95
Compare
Changing the variable to ensure all variable names are following the similar pattern. - Now, cifmw_project_dir will be cifmw_repo_relative and cifmw_project_dir_absolute will be cifmw_repo - Since the absolute values are used in the entire framework, that variable should not have extra keyword (absolute). - The reason to move from `dir` to `repo` is to match the pattern of other variables. Signed-off-by: Amartya Sinha <amsinha@redhat.com>
amartyasinha
force-pushed
the
improve_var_name
branch
from
221cf95 to
01d34b6
Compare
|
recheck |
|
recheck |
|
This change depends on a change that failed to merge. Change #3607 is needed. |
|
recheck |
amartyasinha
merged commit 4205894
into
openstack-k8s-operators:main
4 participants
Changing the variable to ensure all variable names are following the similar pattern.
cifmw_project_dirwill becifmw_repo_relativeandcifmw_project_dir_absolutewill becifmw_repo.dirtorepois to match the pattern of other variables.Depends-On: openstack-k8s-operators/tcib#356
Depends-On: #3607