-
Notifications
You must be signed in to change notification settings - Fork 144
Add OIDC authentication flows tests for federation #3575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
c2c5b11 to
133a0b4
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6784616a5ea14ec68f0010c05d3dfdeb ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 36m 26s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/888f51a660624496a38dbb9ea0ba7425 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 35m 57s |
jagee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me, just wanted see if you though we should remove one duplicate auth test from the older code.
ab83014 to
63dd522
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
f990e8b to
b787b6a
Compare
This adds support for testing all OIDC authentication methods: - v3oidcpassword (Resource Owner Password Credentials) - v3oidcclientcredentials (Client Credentials) - v3oidcaccesstoken (Access Token Reuse) - v3oidcauthcode (Authorization Code) Note: v3oidcdeviceauthz requires Python 3.10+ and is not available in OSP18 which ships with Python 3.9. Signed-off-by: Grzegorz Grasza <xek@redhat.com>
|
Hi @xek , thanks for the patch and thanks for including test results, but please don't directly share downstream links (e.g. links to our private gitlab instance or downstream zuul) here on github. It's technically a leak, no matter how small and insignificant. Instead, include a link to a jira ticket here on github, and on that ticket, include the downstream link in a comment marked as 'Restricted to Red Hat Employee'. Thanks! |
This adds support for testing all OIDC authentication methods:
New features:
Note: v3oidcdeviceauthz requires Python 3.10+ and is not
available in OSP18 which ships with Python 3.9.