feat: add identity.get_user_domain_id method
#493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Bencher Report| Branch | user_domain_id |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| fernet token/project | 📈 view plot 🚷 view threshold | 1,415.10 ns(-3.31%)Baseline: 1,463.52 ns | 1,548.18 ns (91.40%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 147.71 ns(-3.55%)Baseline: 153.14 ns | 189.82 ns (77.82%) |
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
gtema
force-pushed
the
user_domain_id
branch
2 times, most recently
from
15d243e to
6f6d2cb
Compare
There are lot of cases where it is necessary to determine the `domain_id` by the `user_id`. Fetching the whole user is relatively expensive due to the multiple table joins while the attribute itself is present already on the main table entry. Implement a method that only returns the `domain_id` attribute by the `user_id`. Since this data can never change (unless somebody mess directly in the database) caching can be implemented to further improve the performance (when `conf.identity.caching` is true).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are lot of cases where it is necessary to determine the
domain_idby theuser_id. Fetching the whole user is relativelyexpensive due to the multiple table joins while the attribute itself is
present already on the main table entry. Implement a method that only
returns the
domain_idattribute by theuser_id. Since this data cannever change (unless somebody mess directly in the database) caching can
be implemented to further improve the performance (when
conf.identity.cachingis true).