AZ fixes for servers, add DNS entries, fix provisioner #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Notably this is branched off the existing Codemash work. So it should go after #19 |
Member
|
Rats, #19 is the one we don't want to merge in before this week but that we wanted to pick out some smaller changes from lol. |
ryapric
force-pushed
the
fix/azs-for-serves
branch
from
7d1db83 to
0b560c6
Compare
ryapric
reviewed
Jan 12, 2025
ryapric
changed the title
ryapric
approved these changes
Jan 13, 2025
Member
ryapric
left a comment
ryapric
left a comment
There was a problem hiding this comment.
Looks good, I deployed 20 Team servers to test the provisioner fix, and the DNS stuff all works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeah I put DNS stuff in here too, sorry for the branch name
Testing:
DNS
AZs
