-
Notifications
You must be signed in to change notification settings - Fork 223
USHIFT-6519: Switch to using RHEL 9.8 in bootc presubmits and periodics #6202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
a6bc765
0830b95
cb1e511
0977d9c
01cab47
4f4e0b4
33a49e8
25b49e7
e63bdd7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| FROM localhost/rhel96-bootc-source:latest | ||
| FROM localhost/rhel98-bootc-source:latest | ||
| # Create another label for the source container image without any changes |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| {{- if and (env.Getenv "UNAME_M" "") (eq "x86_64" .Env.UNAME_M) }} | ||
| localhost/rhel96-bootc-source-ai-model-serving:latest | ||
| localhost/rhel98-bootc-source-ai-model-serving:latest | ||
| {{- end }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| localhost/rhel98-bootc-source-isolated:latest |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ scenario_create_vms() { | |
| exit_if_image_not_found "${start_image}" | ||
|
|
||
| prepare_kickstart host1 kickstart-bootc.ks.template "${start_image}" | ||
| launch_vm --boot_blueprint rhel96-bootc | ||
| launch_vm --boot_blueprint rhel98-bootc | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check boot_blueprint and start_image patterns in scenario files
echo "=== Checking el9X@elYY upgrade scenarios ==="
fd -e sh test/scenarios-bootc/presubmits/ | grep '@' | while read file; do
echo "--- $file ---"
grep -E '(start_image|boot_blueprint)' "$file" | head -6
doneRepository: openshift/microshift Length of output: 559 🏁 Script executed: #!/bin/bash
# Fix: use correct fd syntax
echo "=== Checking upgrade scenarios (el9X@elYY pattern) ==="
fd '@' test/scenarios-bootc/presubmits/ --type f | while read file; do
echo "--- $(basename "$file") ---"
grep -E '(start_image|boot_blueprint)' "$file" | grep -v '^#'
echo
doneRepository: openshift/microshift Length of output: 2766 Change boot blueprint back to rhel96-bootc. The boot blueprint should match the start image version. All other upgrade scenarios follow this pattern: 🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| scenario_remove_vms() { | ||
|
|
@@ -21,7 +21,7 @@ scenario_run_tests() { | |
| exit_if_image_not_found "${start_image}" | ||
|
|
||
| run_tests host1 \ | ||
| --variable "TARGET_REF:rhel96-bootc-source" \ | ||
| --variable "TARGET_REF:rhel98-bootc-source" \ | ||
| --variable "BOOTC_REGISTRY:${MIRROR_REGISTRY_URL}" \ | ||
| suites/upgrade/upgrade-successful.robot | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
.prefix:PHONYshould be.PHONY.Line 76 declares
PHONY:instead of.PHONY:, sotest-build-ostree-presubmitwon't actually be marked as phony. Make will treatPHONYas a real target.Proposed fix
🧰 Tools
🪛 checkmake (0.2.2)
[warning] 76-76: Target "PHONY" should be declared PHONY.
(phonydeclared)
🤖 Prompt for AI Agents