OCPBUGS-70302: Fix handling of binary data in SecretFormWrapper

[Leo6Leo]

Description

Fixed a JavaScript error that occurred when attempting to edit a Secret containing both binary files and text literals. The Console would crash with "Something wrong happened: Cannot set properties of null" instead of loading the Edit Secret form.

Root Cause

In SecretFormWrapper.tsx, the stringData initialization used a reduce function that returned null when encountering binary data. This broke the accumulator chain, causing subsequent text entries to fail when trying to set properties on null.

Steps to Reproduce

1. Create a binary file and a Secret with mixed data:

   head -c 256 /dev/urandom > binary_file.bin
   oc create secret generic test-ocp-secret \
     --from-file=JGROUPS_ENCRYPTION=binary_file.bin \
     --from-literal=JGROUPS_KEYSTORE_PASSWORD=abcd1234

2. Log into the OpenShift Web Console
3. Navigate to Workloads → Secrets, find test-ocp-secret
4. Click Actions → Edit Secret

Before: Console crashes with "Cannot set properties of null (setting 'JGROUPS_KEYSTORE_PASSWORD')"
After: Edit Secret form loads successfully, displaying both entries

Note: this PR need to get backported to older versions to 4.14.

[openshift-ci-robot]

@Leo6Leo: This pull request references CONSOLE-4631 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Fixed a JavaScript error that occurred when attempting to edit a Secret containing both binary files and text literals. The Console would crash with "Something wrong happened: Cannot set properties of null" instead of loading the Edit Secret form.

Root Cause

In SecretFormWrapper.tsx, the stringData initialization used a reduce function that returned null when encountering binary data. This broke the accumulator chain, causing subsequent text entries to fail when trying to set properties on null.

Steps to Reproduce

1. Create a binary file and a Secret with mixed data:

  head -c 256 /dev/urandom > binary_file.bin
  oc create secret generic test-ocp-secret \
    --from-file=JGROUPS_ENCRYPTION=binary_file.bin \
    --from-literal=JGROUPS_KEYSTORE_PASSWORD=abcd1234

2. Log into the OpenShift Web Console
3. Navigate to Workloads → Secrets, find test-ocp-secret
4. Click Actions → Edit Secret

Before: Console crashes with "Cannot set properties of null (setting 'JGROUPS_KEYSTORE_PASSWORD')"
After: Edit Secret form loads successfully, displaying both entries

Note: this PR need to get backported to older versions to 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Modified the reduce operation in SecretFormWrapper.tsx to handle binary data entries by continuing with the accumulator instead of returning null, preventing invalid results when filtering binary keys from stringData.

Changes

Cohort / File(s)	Summary
Binary Data Filtering frontend/public/components/secrets/create-secret/SecretFormWrapper.tsx	Updated reduce logic to skip binary entries by continuing the accumulator rather than returning null, preserving non-binary data while omitting binary keys from stringData

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 24830e3 and ba7427f.

📒 Files selected for processing (1)

• frontend/public/components/secrets/create-secret/SecretFormWrapper.tsx

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/public/components/secrets/create-secret/SecretFormWrapper.tsx

🔇 Additional comments (1)

frontend/public/components/secrets/create-secret/SecretFormWrapper.tsx (1)

60-68: LGTM! The fix correctly prevents the null accumulator issue.

The change on line 63 properly preserves the accumulator when binary data is encountered, preventing the "Cannot set properties of null" crash. This ensures that subsequent text entries can be processed correctly when editing Secrets containing mixed binary and text data.

The logic correctly separates binary data (stored in base64StringData) from text data (decoded and stored in stringData).

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Leo6Leo
Once this PR has been reviewed and has the lgtm label, please assign vikram-raj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@Leo6Leo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-images	ba7427f	link	true	/test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Leo6Leo]

Close this PR as it is a duplicate fix of #15820

[openshift-ci-robot]

@Leo6Leo: This pull request references Jira Issue OCPBUGS-70302, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description

Fixed a JavaScript error that occurred when attempting to edit a Secret containing both binary files and text literals. The Console would crash with "Something wrong happened: Cannot set properties of null" instead of loading the Edit Secret form.

Root Cause

In SecretFormWrapper.tsx, the stringData initialization used a reduce function that returned null when encountering binary data. This broke the accumulator chain, causing subsequent text entries to fail when trying to set properties on null.

Steps to Reproduce

1. Create a binary file and a Secret with mixed data:

  head -c 256 /dev/urandom > binary_file.bin
  oc create secret generic test-ocp-secret \
    --from-file=JGROUPS_ENCRYPTION=binary_file.bin \
    --from-literal=JGROUPS_KEYSTORE_PASSWORD=abcd1234

2. Log into the OpenShift Web Console
3. Navigate to Workloads → Secrets, find test-ocp-secret
4. Click Actions → Edit Secret

Before: Console crashes with "Cannot set properties of null (setting 'JGROUPS_KEYSTORE_PASSWORD')"
After: Edit Secret form loads successfully, displaying both entries

Note: this PR need to get backported to older versions to 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.