OCPCLOUD-3386: Add platform-specific feature gates for CAPI Operator features#2730
OCPCLOUD-3386: Add platform-specific feature gates for CAPI Operator features#2730mdbooth wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@mdbooth: This pull request references OCPCLOUD-3386 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @mdbooth! Some important instructions when contributing to openshift/api: |
📝 WalkthroughWalkthroughAdds provider-specific feature gates: ClusterAPIMachineManagementAWS, ClusterAPIMachineManagementAzure, ClusterAPIMachineManagementBareMetal, ClusterAPIMachineManagementGCP, ClusterAPIMachineManagementOpenStack, ClusterAPIMachineManagementPowerVS, MachineAPIMigrationAWS, and MachineAPIMigrationOpenStack. Updates FeatureGateMachineAPIMigration metadata (Jira component, contact person, enhancement PR). Adds corresponding entries in features.md and features/features.go, and inserts the new gates into multiple payload-manifests featureGate YAMLs for Hypershift and SelfManagedHA profiles, placed in enabled or disabled lists per profile. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
a123a35 to
0d497f0
Compare
|
Scheduling tests matching the |
|
/recheck-required |
This adds platform-specific feature gates covering: * ClusterAPIMachineManagement - installation of CAPI controllers * MachineAPIMigration - automatic conversion between MAPI and CAPI resources The CAPI Operator currently contains hard-coded logic to enable support on all platforms which have implementations. This set of feature gates is sufficient to cover all platforms which currently have implementations, such that they eventually be promoted independently.
0d497f0 to
9c5267b
Compare
|
/lgtm |
|
@JoelSpeed: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-serial-techpreview-2of2 |
ⓘ Your monthly quota for Qodo has expired. Upgrade your plan ⓘ Paying users. Check that your Qodo account is linked with this Git user account |
|
/retest-required |
|
/test e2e-aws-serial-1of2 minor-e2e-upgrade-minor |
ⓘ Your monthly quota for Qodo has expired. Upgrade your plan ⓘ Paying users. Check that your Qodo account is linked with this Git user account |
|
@mdbooth: This pull request references OCPCLOUD-3386 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-techpreview |
ⓘ Your monthly quota for Qodo has expired. Upgrade your plan ⓘ Paying users. Check that your Qodo account is linked with this Git user account |
|
/test e2e-aws-serial-1of2 e2e-aws-serial-techpreview-1of2 e2e-azure e2e-gcp |
ⓘ Your monthly quota for Qodo has expired. Upgrade your plan ⓘ Paying users. Check that your Qodo account is linked with this Git user account |
|
/test e2e-aws-ovn-hypershift-conformance |
ⓘ Your monthly quota for Qodo has expired. Upgrade your plan ⓘ Paying users. Check that your Qodo account is linked with this Git user account |
|
@mdbooth: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This adds platform-specific feature gates covering:
The CAPI Operator currently contains hard-coded logic to enable support on all platforms which have implementations. This set of feature gates is sufficient to cover all platforms which currently have implementations, such that they can eventually be promoted independently.