Skip to content

OCPCLOUD-3386: Add platform-specific feature gates for CAPI Operator features#2730

Open
mdbooth wants to merge 1 commit intoopenshift:masterfrom
openshift-cloud-team:capio-platform-featuregates
Open

OCPCLOUD-3386: Add platform-specific feature gates for CAPI Operator features#2730
mdbooth wants to merge 1 commit intoopenshift:masterfrom
openshift-cloud-team:capio-platform-featuregates

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Feb 26, 2026

This adds platform-specific feature gates covering:

  • ClusterAPIMachineManagement - installation of CAPI controllers
  • MachineAPIMigration - automatic conversion between MAPI and CAPI resources

The CAPI Operator currently contains hard-coded logic to enable support on all platforms which have implementations. This set of feature gates is sufficient to cover all platforms which currently have implementations, such that they can eventually be promoted independently.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2026

@mdbooth: This pull request references OCPCLOUD-3386 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This adds platform-specific feature gates covering:

  • ClusterAPIMachineManagement - installation of CAPI controllers
  • MachineAPIMigration - automatic conversion between MAPI and CAPI resources

The CAPI Operator currently contains hard-coded logic to enable support on all platforms which have implementations. This set of feature gates is sufficient to cover all platforms which currently have implementations, such that they eventually be promoted independently.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

Hello @mdbooth! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

📝 Walkthrough

Walkthrough

Adds provider-specific feature gates: ClusterAPIMachineManagementAWS, ClusterAPIMachineManagementAzure, ClusterAPIMachineManagementBareMetal, ClusterAPIMachineManagementGCP, ClusterAPIMachineManagementOpenStack, ClusterAPIMachineManagementPowerVS, MachineAPIMigrationAWS, and MachineAPIMigrationOpenStack. Updates FeatureGateMachineAPIMigration metadata (Jira component, contact person, enhancement PR). Adds corresponding entries in features.md and features/features.go, and inserts the new gates into multiple payload-manifests featureGate YAMLs for Hypershift and SelfManagedHA profiles, placed in enabled or disabled lists per profile.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding platform-specific feature gates for CAPI Operator features, with direct reference to the relevant Jira ticket.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description accurately describes the changes: adding platform-specific feature gates for ClusterAPIMachineManagement and MachineAPIMigration, relating directly to the changeset modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 26, 2026
@mdbooth mdbooth force-pushed the capio-platform-featuregates branch from a123a35 to 0d497f0 Compare February 26, 2026 16:59
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@openshift-ci-robot
Copy link

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026
@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 26, 2026

/recheck-required

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2026
This adds platform-specific feature gates covering:
* ClusterAPIMachineManagement - installation of CAPI controllers
* MachineAPIMigration - automatic conversion between MAPI and CAPI
  resources

The CAPI Operator currently contains hard-coded logic to enable support
on all platforms which have implementations. This set of feature gates
is sufficient to cover all platforms which currently have
implementations, such that they eventually be promoted independently.
@mdbooth mdbooth force-pushed the capio-platform-featuregates branch from 0d497f0 to 9c5267b Compare February 27, 2026 15:59
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
@JoelSpeed
Copy link
Contributor

/lgtm
/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 27, 2026
@openshift-ci-robot
Copy link

@JoelSpeed: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
@openshift-ci-robot
Copy link

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JoelSpeed,everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 27, 2026

/test e2e-aws-serial-techpreview-2of2

@qodo-code-review
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 27, 2026

/retest-required

@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 27, 2026

/test e2e-aws-serial-1of2 minor-e2e-upgrade-minor

@qodo-code-review
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2026

@mdbooth: This pull request references OCPCLOUD-3386 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This adds platform-specific feature gates covering:

  • ClusterAPIMachineManagement - installation of CAPI controllers
  • MachineAPIMigration - automatic conversion between MAPI and CAPI resources

The CAPI Operator currently contains hard-coded logic to enable support on all platforms which have implementations. This set of feature gates is sufficient to cover all platforms which currently have implementations, such that they can eventually be promoted independently.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 27, 2026

/test e2e-aws-ovn-techpreview

@qodo-code-review
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 27, 2026

/test e2e-aws-serial-1of2 e2e-aws-serial-techpreview-1of2 e2e-azure e2e-gcp

@qodo-code-review
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 27, 2026

/test e2e-aws-ovn-hypershift-conformance

@qodo-code-review
Copy link

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan
ⓘ Paying users. Check that your Qodo account is linked with this Git user account

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2026

@mdbooth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-1of2 9c5267b link true /test e2e-aws-serial-1of2
ci/prow/e2e-azure 9c5267b link true /test e2e-azure
ci/prow/e2e-aws-serial-techpreview-1of2 9c5267b link true /test e2e-aws-serial-techpreview-1of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants