Bugfix/154 colorstate comparison fails when comparing with null values#155
Open
DivineThreepwood wants to merge 3 commits intodevfrom
Open
Conversation
✅ Deploy Preview for basecubeone canceled.
|
DivineThreepwood
added
the
preview
lhuxohl
requested changes
Feb 19, 2026
| boolean saturationEquals = true; | ||
| boolean brightnessEquals = true; | ||
| // normalize angle to [0,360) | ||
| java.util.function.DoubleUnaryOperator normalize = (v) -> { |
Contributor
There was a problem hiding this comment.
Can't we import DoubleUnaryOperator?
|
|
||
| if(hsbColorA.hasHue() && hsbColorB.hasHue()) { | ||
| hueEquals = OperationService.equals(hsbColorA.getHue(), hsbColorB.getHue(), 1.0); | ||
| java.util.function.BiPredicate<Double, Double> hueEqualsWithWrap = (ha, hb) -> { |
| @Test | ||
| @Timeout(10) | ||
| @Throws(VerificationFailedException::class, JPServiceException::class) | ||
| fun verifyColorState() { |
Contributor
There was a problem hiding this comment.
why is this test not named with fun ``?
|
|
||
| class ColorStateProviderServiceTest { | ||
| @Test | ||
| @Timeout(10) |
Contributor
There was a problem hiding this comment.
Why is the timeout necessary? Is this test time sensitive?
| class ColorStateProviderServiceTest { | ||
| @Test | ||
| @Timeout(10) | ||
| @Throws(VerificationFailedException::class, JPServiceException::class) |
Contributor
There was a problem hiding this comment.
How about using assertThrows where needed
| val verifiedColorState = ColorStateProviderService.verifyColorState(builder.build()) | ||
| ExceptionPrinter.setBeQuit(false) | ||
|
|
||
| Assertions.assertEquals( |
Contributor
There was a problem hiding this comment.
In other Test we prefer shouldBeEqual. I think we should also switch this here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Changes proposed in this pull request:
✅ Checklist: