fix parallel tool calls #7956
Open
fix parallel tool calls #7956
+307
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@codex review this |
pakrym-oai
reviewed
Dec 13, 2025
| config.model_provider.stream_max_retries = Some(0); | ||
| config.model_provider.stream_idle_timeout_ms = Some(5_000); | ||
| }); | ||
| let test = builder.build(&mock_server).await?; |
Collaborator
There was a problem hiding this comment.
Feels pretty useless, to pass mock server here.
Collaborator
There was a problem hiding this comment.
the only thing we need from server is the URI, consider an overload maybe?
you can hide let base_url = format!("{}/v1", streaming_server.uri()); there.
pakrym-oai
reviewed
Dec 13, 2025
| builder = builder.with_config(move |config| { | ||
| config.model_provider.base_url = Some(base_url); | ||
| config.model_provider.request_max_retries = Some(0); | ||
| config.model_provider.stream_max_retries = Some(0); |
Collaborator
There was a problem hiding this comment.
Ideally we don't need to set these in the test.
Contributor
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.