Skip to content

Conversation

@demfabris
Copy link

@demfabris demfabris commented Dec 12, 2025

Fixes a file-search behavior where ignore rules from parent directories above the search root could incorrectly exclude results.

  • Always set WalkBuilder::parents(false) so ignore rules don’t leak from above the search root
  • Adds regression tests verifying parent .gitignore does not apply, while root .gitignore still does
image

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@demfabris
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 12, 2025
@etraut-openai
Copy link
Collaborator

etraut-openai commented Dec 12, 2025

Thanks for the contribution. Is there an active bug report associated with this PR? We ask that all PRs have bug reports linked to them. It helps us track and prioritize issues, especially in cases where a PR is rejected but the bug remains.

In this particular case, I'm not sure the proposed change is desirable. I'd like to better understand what problem this is solving, so a bug report would also help there.

@etraut-openai etraut-openai added the needs-response Additional information is requested label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-response Additional information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants