fix: PHP 8.4 compatibility - TypeError when API returns null for results array

[Natshah]

What:

• Bug Fix
• New Feature

Description:

Related:

[iBotPeaches]

thanks! A lot of the strict typing never expects null there so you'll see the test suite is not accounting for this discrepancy.

[iBotPeaches]

Are you experiencing this with OpenAI or some 3rd party workaround? Confused as I heavily use this moderation endpoint and never experience this.

[Natshah]

Thanks, Connor, for follow up on the PHP 8.4 issue.

Using this with the Drupal AI integration module with Drupal
And the OpenAI Provider

OpenAI\Responses\Moderations\CreateResponse::from() (Line: 30)
OpenAI\Resources\Moderations->create() (Line: 726)
Drupal\ai_provider_openai\Plugin\AiProvider\OpenAiProvider->moderationEndpoints() (Line: 350)
Drupal\ai_provider_openai\Plugin\AiProvider\OpenAiProvider->chat()
ReflectionMethod->invokeArgs() (Line: 269)
Drupal\ai\Plugin\ProviderProxy->wrapperCall() (Line: 133)
Drupal\ai\Plugin\ProviderProxy->__call() (Line: 149)
Drupal\ai_ckeditor\Controller\AiRequest->doRequest()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::wrapControllerExecutionInRenderContext():121}() (Line: 634)

Doing number of testing rounds, ( Automated Functional Testing )

[iBotPeaches]

Thanks for follow up and sorry for delay. I guess I'm just confused - with the changes you've made you've effectively said anything can be null on the moderation endpoint. Down to the results, id and model but also use OpenAI where I've never experienced that.

Am I missing something? Is this some mutation testing? or different model? circumstance?