Open
Conversation
Collaborator
|
@maina-david Could you please provide some background information why this change is needed? |
Author
|
@gehrisandro HttpDiscovery is not an HTTP client itself but rather a library that helps one discover available PSR-18 client implementations in the environment. It allows the package to be more flexible and not tied to a specific HTTP client implementation like Symfony HttpClient. |
Collaborator
|
Thank you for clarification. This sounds like a reasonable decision. Will check if everything is compatible with the other packages and then going to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update Psr18Client in client