Skip to content

Conversation

@JerryVincent
Copy link
Collaborator

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • [ x ] New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

Checklist

  • [✔️] I gave this pull request a meaningful title
  • [ ✔️] My pull request is targeting the dev branch
  • [✔️ ] I have added documentation to my code
  • [ ✔️] I have deleted code that I have commented out

Additional Information

@scheidtdav
Copy link
Collaborator

Hmm what exactly did you do here @JerryVincent ?
It seems to not be working for me. I can get to the "General" section of the device data but as soon as I click any other entry on the left hand side (like "sensors"), I am greeted with an error message.

Am I missing something? Could you explain what exactly you did in this PR?
It is difficult to figure out just by code, because of the formatting.

One more thing: I noticed there are some hard-coded english strings.
Please merge dev into your branch and check if these have been covered by the recent efforts of translating everything.
If not, please add them to the resources. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow editing of details of a device

3 participants