Skip to content

Conversation

@gurnoorpannu
Copy link
Contributor

@gurnoorpannu gurnoorpannu commented Jan 26, 2026

Fixes - Jira-#MIFOSAC-632

Before:

WhatsApp.Video.2026-01-27.at.15.17.47.mp4

After:

WhatsApp.Video.2026-01-27.at.15.19.26.mp4

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Summary by CodeRabbit

  • Bug Fixes
    • Improved back button navigation handling on the Collateral Details screen, ensuring proper navigation flow when users return to the previous screen.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

Updates ClientCollateralDetailScreen navigation to accept an onNavigateBack callback parameter, which is passed through the navigation route and integrated with MifosScaffold's back button handler, enabling proper navigation flow control.

Changes

Cohort / File(s) Summary
Navigation Route Updates
feature/client/src/commonMain/kotlin/com/mifos/feature/client/clientCollateralDetails/ClientCollateralDetailRoute.kt
Added named parameter navController and new onNavigateBack callback that invokes navController.navigateUp() when back navigation is triggered
Screen Composable Updates
feature/client/src/commonMain/kotlin/com/mifos/feature/client/clientCollateralDetails/ClientCollateralDetailScreen.kt
Added onNavigateBack parameter to both ClientCollateralDetailScreen and ClientCollateralDetailScreenContent composables; wired callback to MifosScaffold's onBackPressed handler

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • revanthkumarJ
  • niyajali

Poem

🐰 A rabbit hops back through the collateral maze,
With callbacks now guiding through navigation's phase,
Each detail screen knows when to retreat with grace,
Back buttons aligned in their proper place! 🔙✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding back-navigation functionality to the ClientCollateralDetailScreen component, which aligns with the code changes in the pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@biplab1 biplab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This can be merged.

@biplab1
Copy link
Contributor

biplab1 commented Jan 27, 2026

@gurnoorpannu Can you please update branch? After this, you may request for merge.

@gurnoorpannu
Copy link
Contributor Author

@gurnoorpannu Can you please update branch? After this, you may request for merge.

sure sir

@biplab1
Copy link
Contributor

biplab1 commented Jan 28, 2026

@niyajali Could you please merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants