Fix AttributeError on invalid attribute type in Python 3.9#4905
Open
MikeGoldsmith wants to merge 4 commits intoopen-telemetry:mainfrom
Open
Fix AttributeError on invalid attribute type in Python 3.9#4905MikeGoldsmith wants to merge 4 commits intoopen-telemetry:mainfrom
MikeGoldsmith wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
typing.Mapping lacks __name__ in py39, causing AttributeError instead of TypeError when invalid types passed to attributes. Fixes open-telemetry#4821
Contributor
|
Isn't this a dup of #4876 ? |
Member
Author
Ah, yes it is. This PR updates more locations and has more testing, but happy to close in favour of the other one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes AttributeError when invalid attribute types are passed in Python 3.9. The
typing.Mappingtype lacks__name__attribute in py39, causing error message generation to fail with AttributeError instead of the intended TypeError.Added
_get_type_name()helper to safely extract type names from both regular types and typing generics.Fixes:
Type of change
How Has This Been Tested?
test_invalid_type_error_messageDoes This PR Require a Contrib Repo Change?
Checklist: