fix(logging): apply format/level when logging preconfigured#4204
Open
MikeGoldsmith wants to merge 6 commits intoopen-telemetry:mainfrom
Open
fix(logging): apply format/level when logging preconfigured#4204MikeGoldsmith wants to merge 6 commits intoopen-telemetry:mainfrom
MikeGoldsmith wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
basicConfig() no-op when handlers exist (autoinstrumentation, Gunicorn, Flask). Fix: update existing handlers instead of only calling basicConfig. Saves/restores state for clean uninstrumentation. Supersedes open-telemetry#2384, fixes open-telemetry#2346
7 tasks
…-contrib into mike/fix-logging-preconfigured
- Clear handlers before basicConfig tests - Run ruff format
caplog doesn't capture when basicConfig called before fixture setup. Use custom handler to capture records instead.
xrmx
reviewed
Feb 16, 2026
| LoggingInstrumentor().uninstrument() | ||
|
|
||
| # Clear handlers to ensure basicConfig is called | ||
| root = logging.getLogger() |
Contributor
There was a problem hiding this comment.
Do you think mocking hasHandlers will work as well?
Member
Author
There was a problem hiding this comment.
Oh, good idea - I'll take a look at doing that 👍🏻
Member
Author
|
Looks like a flakey test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes logging instrumentation when logging is already configured (autoinstrumentation, Gunicorn, Flask).
Problem:
logging.basicConfig()is a no-op when root logger has handlers. OTel trace context gets injected but isn't visible because format string doesn't include the fields.Solution: Added
_apply_log_settings()that checks if root logger has handlers and updates existing handler formatters + level, or falls back tobasicConfig(). Saves/restores old state for clean uninstrumentation.Supersedes #2384
Fixes #2346
Type of change
How Has This Been Tested?
#Does This PR Require a Core Repo Change?
Checklist: