Try out basedpyright with baseline file#4195
Draft
aabmass wants to merge 1 commit intoopen-telemetry:mainfrom
Draft
Try out basedpyright with baseline file#4195aabmass wants to merge 1 commit intoopen-telemetry:mainfrom
aabmass wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
bc062ed to
1916386
Compare
aabmass
commented
Feb 13, 2026
Comment on lines
1105
to
1115
| @@ -1115,4 +1115,4 @@ deps = | |||
| {toxinidir}/instrumentation/opentelemetry-instrumentation-aiohttp-client[instruments] | |||
Member
Author
There was a problem hiding this comment.
I imagine many errors could be removed by adding all new instrumentations here too.
1916386 to
6d3678a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables typechecking on python packages, examples, tests in the repo using basedpyright's baseline feature https://docs.basedpyright.com/latest/benefits-over-pyright/baseline/
Downsides to this approach:
.basedpyright/baseline.jsonis pretty enormousBenefit:
# type: ignore