Skip to content

Try out basedpyright with baseline file#4195

Draft
aabmass wants to merge 1 commit intoopen-telemetry:mainfrom
aabmass:push-tlmxkvxpylln
Draft

Try out basedpyright with baseline file#4195
aabmass wants to merge 1 commit intoopen-telemetry:mainfrom
aabmass:push-tlmxkvxpylln

Conversation

@aabmass
Copy link
Member

@aabmass aabmass commented Feb 13, 2026

Enables typechecking on python packages, examples, tests in the repo using basedpyright's baseline feature https://docs.basedpyright.com/latest/benefits-over-pyright/baseline/

Downsides to this approach:

Benefit:

  • All new code even in existing files will be forced to type check
  • Don't litter codebase with # type: ignore

Comment on lines 1105 to 1115
@@ -1115,4 +1115,4 @@ deps =
{toxinidir}/instrumentation/opentelemetry-instrumentation-aiohttp-client[instruments]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine many errors could be removed by adding all new instrumentations here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments