asgi: use test_base helpers where possible and otherwise filter scope#4122
Merged
xrmx merged 4 commits intoopen-telemetry:mainfrom Feb 4, 2026
Merged
asgi: use test_base helpers where possible and otherwise filter scope#4122xrmx merged 4 commits intoopen-telemetry:mainfrom
xrmx merged 4 commits intoopen-telemetry:mainfrom
Conversation
xrmx
reviewed
Jan 26, 2026
instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py
Outdated
Show resolved
Hide resolved
xrmx
approved these changes
Feb 4, 2026
wikaaaaa
pushed a commit
to wikaaaaa/opentelemetry-python-contrib
that referenced
this pull request
Feb 5, 2026
…open-telemetry#4122) * asgi: use test_base helpers where possible and otherwise filter scope * Pass scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am helping implement SDK metrics in open-telemetry/opentelemetry-python#4880. By nature of their definition, they are present by usage of the SDK itself, meaning the metrics are populated in instrumentation tests too. Unfortunately, many instrumentation tests have strict checks on generated metrics so extra metrics cause them to fail.
@xrmx suggested we can try adding filtering in TestBase, and using TestBase more instead of doing management in unit tests simplifies them anyways, so I am helping with these migrations. Some locations do manual filtering locally where still needed until having access to a new helper in TestBase.
As it's testing infrastructure only, this PR should be skip-changelog.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.