Skip to content

Reduce severity & verbosity of instrumentation ImportError (#1115) #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
john-karp wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Reduce severity & verbosity of instrumentation ImportError (#1115) #4064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...telemetry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/_load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def _load_instrumentors(distro):
# environment regarding python version, libc, etc... In this case it's better
# to skip the single instrumentation rather than failing to load everything
# so treat differently ImportError than the rest of exceptions
_logger.exception(
_logger.warning(
"Importing of %s failed, skipping it", entry_point.name
)
continue
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-instrumentation/tests/auto_instrumentation/test_load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ def test_load_instrumentors_import_error_does_not_stop_everything(
]
)
self.assertEqual(distro_mock.load_instrumentor.call_count, 2)
mock_logger.exception.assert_any_call(
mock_logger.warning.assert_any_call(
"Importing of %s failed, skipping it",
ep_mock1.name,
)
Expand Down