-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: Add support for SOFARPC framework #15589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0 through 5.12.0+ Fixes open-telemetry#15496
...main/java/io/opentelemetry/javaagent/instrumentation/sofa/rpc/OpenTelemetryClientFilter.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/javaagent/instrumentation/sofa/rpc/SofaRpcInstrumentationModule.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/javaagent/instrumentation/sofa/rpc/SofaRpcInstrumentationModule.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/instrumentation/sofa/rpc/internal/SofaRpcClientNetworkAttributesGetter.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/instrumentation/sofa/rpc/internal/SofaRpcClientNetworkAttributesGetter.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/instrumentation/sofa/rpc/internal/SofaRpcClientNetworkAttributesGetter.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/instrumentation/sofa/rpc/internal/SofaRpcClientNetworkAttributesGetter.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/instrumentation/sofa/rpc/internal/SofaRpcClientNetworkAttributesGetter.java
Outdated
Show resolved
Hide resolved
...io/opentelemetry/instrumentation/sofa/rpc/internal/SofaRpcClientNetworkAttributesGetter.java
Outdated
Show resolved
Hide resolved
...nfigure/src/main/java/io/opentelemetry/instrumentation/sofa/rpc/SofaRpcAttributesGetter.java
Outdated
Show resolved
Hide resolved
...ain/java/io/opentelemetry/instrumentation/sofa/rpc/SofaRpcNetworkServerAttributesGetter.java
Outdated
Show resolved
Hide resolved
...nfigure/src/main/java/io/opentelemetry/instrumentation/sofa/rpc/SofaRpcTelemetryBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive instrumentation support for the SOFARPC framework, enabling distributed tracing for RPC calls. The implementation includes both javaagent-based auto-instrumentation and library-based manual instrumentation approaches, with full support for synchronous, asynchronous, and generic invocations.
Key changes:
- Adds javaagent instrumentation module with automatic filter injection via SPI
- Adds library autoconfigure module with manual instrumentation API
- Implements comprehensive test coverage including chain tracing, error handling, async calls, and local call detection
- Supports SOFARPC versions 5.4.0 through 5.12.0+
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Adds three new subprojects for SOFARPC instrumentation (javaagent, library-autoconfigure, testing) |
| instrumentation/sofa-rpc/metadata.yaml | Defines instrumentation metadata including supported versions, semantic conventions, and configuration options |
| instrumentation/sofa-rpc/testing/build.gradle.kts | Configures test dependencies and runtime classpath with SOFARPC 5.4.0 and compatible logging dependencies |
| instrumentation/sofa-rpc/testing/src/main/java/.../api/* | Defines test service interfaces (HelloService, MiddleService, ErrorService) for testing RPC scenarios |
| instrumentation/sofa-rpc/testing/src/main/java/.../impl/* | Implements test services including error handling, chaining, and timeout scenarios |
| instrumentation/sofa-rpc/testing/src/main/java/.../AbstractSofaRpcTest.java | Provides base test class for synchronous, asynchronous, and error handling test scenarios |
| instrumentation/sofa-rpc/testing/src/main/java/.../AbstractSofaRpcTraceChainTest.java | Tests trace propagation through chained RPC calls and local call filtering |
| instrumentation/sofa-rpc/library-autoconfigure/src/main/java/.../* | Core library instrumentation including telemetry builder, filters, attribute extractors, and context propagation |
| instrumentation/sofa-rpc/library-autoconfigure/src/test/java/.../* | Library instrumentation tests extending abstract test classes |
| instrumentation/sofa-rpc/library-autoconfigure/build.gradle.kts | Configures library dependencies with SOFARPC 5.4.0 and AutoValue for code generation |
| instrumentation/sofa-rpc/library-autoconfigure/src/main/resources/META-INF/services/* | SPI configuration for auto-registering OpenTelemetry filters with SOFARPC |
| instrumentation/sofa-rpc/javaagent/src/main/java/.../* | Javaagent instrumentation module with resource injection and filter delegation |
| instrumentation/sofa-rpc/javaagent/src/testSofaRpc/java/.../* | Javaagent-specific tests with peer service attribute support |
| instrumentation/sofa-rpc/javaagent/build.gradle.kts | Configures javaagent build with muzzle checks for version 5.0.0+ and test suites |
| instrumentation/sofa-rpc/javaagent/src/main/resources/* | SPI configuration for javaagent filter registration |
...ure/src/main/java/io/opentelemetry/instrumentation/sofarpc/v5_4/SofaRpcTelemetryBuilder.java
Outdated
Show resolved
Hide resolved
...autoconfigure/src/main/java/io/opentelemetry/instrumentation/sofarpc/v5_4/TracingFilter.java
Outdated
Show resolved
Hide resolved
...ary-autoconfigure/src/main/java/io/opentelemetry/instrumentation/sofa/rpc/TracingFilter.java
Outdated
Show resolved
Hide resolved
...autoconfigure/src/main/java/io/opentelemetry/instrumentation/sofarpc/v5_4/TracingFilter.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/instrumentation/sofarpc/v5_4/AbstractSofaRpcTraceChainTest.java
Show resolved
Hide resolved
...autoconfigure/src/main/java/io/opentelemetry/instrumentation/sofarpc/v5_4/TracingFilter.java
Outdated
Show resolved
Hide resolved
...testing/src/main/java/io/opentelemetry/instrumentation/sofarpc/v5_4/AbstractSofaRpcTest.java
Show resolved
Hide resolved
...fa-rpc/testing/src/main/java/io/opentelemetry/instrumentation/sofa/rpc/api/ErrorService.java
Outdated
Show resolved
Hide resolved
...testing/src/main/java/io/opentelemetry/instrumentation/sofarpc/v5_4/AbstractSofaRpcTest.java
Show resolved
Hide resolved
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0 through 5.12.0+ Fixes open-telemetry#15496
…va/io/opentelemetry/instrumentation/sofarpc/v5_4/SofaRpcTelemetryBuilder.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0 through 5.12.0+ Fixes open-telemetry#15496
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0+ Fixes open-telemetry#15496
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0+ Fixes open-telemetry#15496
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0+ Fixes open-telemetry#15496
This PR adds instrumentation support for SOFARPC framework, including:
Fixes #15496