Multi BLS added to new bls package#34
Open
tarakby wants to merge 4 commits intofeature/packages-refactorfrom
Open
Multi BLS added to new bls package#34tarakby wants to merge 4 commits intofeature/packages-refactorfrom
bls package#34tarakby wants to merge 4 commits intofeature/packages-refactorfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi BLS added to new
blspackageSummary
This PR continues the crypto package refactoring by integrating multi-signature BLS functionality into the new
blspackage structure. The changes include:blspackageThe PR builds on the foundational work from PR #33, specifically focusing on multi-signature capabilities within the modular package structure. All CI checks are passing, but the complexity of multi-signature cryptographic operations requires thorough manual verification.
Review & Testing Checklist for Human
Recommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TB subgraph "BLS Package Structure" BLSPkg["sign/bls/<br/>bls.go"]:::major-edit MultiBLS["sign/bls/<br/>multi_bls.go"]:::major-edit BLSTests["sign/bls/<br/>bls_test.go"]:::minor-edit end subgraph "Dependencies" BLS12381["bls12381/<br/>curve operations"]:::context SignPkg["sign/<br/>interfaces"]:::context CommonPkg["common/<br/>(removed)"]:::major-edit end subgraph "Import Fixes" ImportFixes["Various files<br/>import statements"]:::minor-edit end BLS12381 --> BLSPkg BLS12381 --> MultiBLS BLSPkg --> SignPkg MultiBLS --> SignPkg CommonPkg -.->|removed| BLSPkg CommonPkg -.->|removed| MultiBLS ImportFixes --> BLSPkg ImportFixes --> MultiBLS subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes