Display GAME CLOSED message when game is closed#8
Merged
jonathan-irvin merged 4 commits intomainfrom Mar 3, 2025
Merged
Conversation
Replace the 'hide board' behavior with a 'GAME CLOSED' message displayed in the same space. This provides better visual feedback to users when the game is closed. - Add new constants for closed message text and color - Create new build_closed_message function that displays large text - Update close_game and sync_board_state to show message instead of hiding board
Instead of hiding the board when the game is closed, display a large 'GAME CLOSED' message in the same space as the board. This provides better visibility and a consistent user experience across all views including the main.py implementation. - Add build_closed_message function to both modules - Update sync_board_state to display message in both modules - Display message using the header font and free space color
- Add proper typing to game_logic, board_builder, and constants - Create dedicated types module for shared type definitions - Fix tests to reflect new closed message functionality - Add mypy type checking to development dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code