Closed
Conversation
- Add fallback to manually run sync_board_state when ui.broadcast() fails - Fix bug where header wouldn't update when game closed in newer NiceGUI versions - Add test to validate fix works when broadcast mechanism unavailable 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add reactive binding for header text using NiceGUI's bind_text_from - Update CLAUDE.md with relevant NiceGUI documentation references - Refactor sync_board_state to use direct module attribute access - Improve broadcast fallback test to focus on critical behavior - Fix issue where header text wouldn't update consistently across views 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
test_header_update_when_broadcast_failsto verify broadcast failure handling🤖 Generated with Claude Code