Add "show-config" subcommand #698
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Just wanted to let you know I will need some more time in order to do a proper review here. I'm very happy the PR is here in any case. |
Contributor
Author
|
No worries, frohe Weihnachten! btw I’m not too happy with the flag parsing, I think my implementation could be improved |
le-lenn
commented
Dec 23, 2025
| } | ||
|
|
||
| for _, config := range configurations { | ||
| if config == nil { |
Contributor
Author
There was a problem hiding this comment.
can config ever be nil since there are many default values?
le-lenn
commented
Dec 26, 2025
cmd/backup/main.go
Outdated
| c := newCommand() | ||
| if flag.Arg(0) == "show-config" { | ||
| c.must(runShowConfig()) | ||
| return |
Contributor
Author
There was a problem hiding this comment.
I think this should first check for an argument. If there is one there should be a switch with the default being an abort because an unknown flag was passed.
Contributor
Author
There was a problem hiding this comment.
And this logic could also live in its own file
le-lenn
force-pushed
the
debug-subcommand
branch
from
18db772 to
13e54e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #628
Approach
I looked into how shouterrr pretty-prints its verify function and tried to find the best poor-mans approach to it.
I wanted to add a little bit of formatting, because without any formatting, the output is pretty hard to read. So I landed on a basic regex based formatter.
I played around with coloring the output as well, but I ended up with a lot of code for a nice-to-have, so I removed it again.