Onboarding ALMAG #1073
Onboarding ALMAG #1073
Conversation
|
|
|
Hello, can you please ensure that your runbot is green 😄 |
I fixed the stylistic issues and it passes the build tests. The only thing that makes it red at this point is the message convention for my first commit (I didn't add [ADD] at the start). For now I want to continue working on the tutorial, but I can fix that later if it's critical? |
|
My recommendation would be to fix your first commit now to maintain a clean base. To achieve this, you can use a simple interactive rebase. 😄 |
lost-odoo
left a comment
lost-odoo
left a comment
There was a problem hiding this comment.
I already made a small review. I just have some nitpicking stuff. Nothing too bad. 😄
estate/__manifest__.py
Outdated
| 'version': '0.1', | ||
| 'depends': ['base', 'web'], | ||
| 'application': True, | ||
| 'installable': True, |
There was a problem hiding this comment.
Here installable is not mandatory as application is set to true. When application is set, installable is automatically set.
There was a problem hiding this comment.
No but I think someone is doing some ci tests to unify the manifests file so it is better to try to keep it at the minimum
magai2002
force-pushed
the
master-onboarding-almag
branch
from
ebdec66 to
0f1ce9e
Compare
|
Hey don't forget to close all the comments I did on the review when you did them 😄 |
3 participants
No description provided.