-
Notifications
You must be signed in to change notification settings - Fork 0
Add submodule for translations #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
DescriptionThis PR add the [nvdaL10n repo](https://github.com/nvdaes/nvdaL10n as a submodule. The addonTemplate branch is added with path _l10n. Note that an l10n.json file can be created in the main project, since storing it in the submodule folder produced an error. @seanbudd and others, please feel free to fork the repo or create pull requests if you consider it appropriate. |
|
Is it possible to just integrate a pre-built l10nUtil.exe rather than the full code? Or do we need individual scripts? |
|
Sean wrote:
I think it's possible, of course preserving required modifications for the template, or you may produce an l10nUtil.exe for both (NVDA and the addon-template). |
|
Also, if this is done, I may not release my translateNvdaAddonsWithCrowdin add-on, in case people prefers to use l10nUtils, since the add-on blocks NVDA when it download translations for specific languages. |
|
I think it would be easiest to just integrate the pre-made exe into NVDA and the template. |
|
I like the idea about a repo for l10nUtil. I imagine that you would create it. Let me know if something is required from my side. |
|
I can ask if we can schedule it. Currently we weren't planning on taking on work for the add-on template, but since this will save us in the long-term development of both NVDA and this template I think we might be able to justify it. |
|
While we wait for that, for now, could you design the add-on template changes in #1 using NVDA's l10nUtil.exe? e.g. just get the exe from a random alpha. we can later turn it into a separate repo using your work in https://github.com/nvdaes/nvdaL10n as a base |
|
I'm copying files into a dummy NVDA branch locally, i.e., modified l10nUtil.py, markdownTranslate.py etc, and then run scons launcher, to build the executable and test locally with docker and act. |
|
I think if we are incorporating an l10nUtil.exe here, it should be signed by us before this is merged. When the PR is ready and working with the exe, please send us the source code in some form so we can create a signed copy |
|
I'm working on this:
I'm thinking about creating a variable named isAddon, False by default, or something like that. We can use my Crowdin project for add-ons, and NV Access Crowdin project for NVDA files. Also, when files are updated, not uploaded to Crowdin for the first time, we use crowdinSync in the add-on template. |
No description provided.