Fix punctuation removal for strings with new line characters#28
Open
tstrachota wants to merge 1 commit intonono:masterfrom
Open
Fix punctuation removal for strings with new line characters#28tstrachota wants to merge 1 commit intonono:masterfrom
tstrachota wants to merge 1 commit intonono:masterfrom
Conversation
The regexp for substitution of the punctuation chars matched with end of line instead if end of the string. That caused the punctuation being removed from the middle of the text when it was followed by a new line.
Author
|
Hi @nono, do you have any opinion on this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regexp for substitution of the punctuation chars matched with end of line instead if end of the string.
That caused the punctuation being removed from the middle of the text when it was followed by a new line.