docs(code-style): commit messages should be in lowercase#8427
Merged
avivkeller merged 1 commit intonodejs:mainfrom Dec 19, 2025
Merged
docs(code-style): commit messages should be in lowercase#8427avivkeller merged 1 commit intonodejs:mainfrom
avivkeller merged 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
araujogui
approved these changes
Dec 18, 2025
avivkeller
approved these changes
Dec 18, 2025
bjohansebas
approved these changes
Dec 18, 2025
aymen94
approved these changes
Dec 18, 2025
flakey5
approved these changes
Dec 18, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8427 +/- ##
==========================================
- Coverage 73.66% 73.64% -0.02%
==========================================
Files 107 107
Lines 9161 9161
Branches 312 312
==========================================
- Hits 6748 6747 -1
- Misses 2411 2412 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As I noticed in my first PR, the guidelines currently state that commit messages need to start with a capital letter. This guideline is not followed so let's change it. I went with @avivkeller 's recommendation, the convention most repos follow: only lowercase except for proper nouns.
Validation
N/A
Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.